Update Pulpcore to 3.39

[ianballou]

Related:

• Fixes #36903 - upgrade to Pulpcore 3.39 Katello/katello#10791
• Update bindings requirements for rubygem-katello foreman-packaging#9958
• Pulpcore 3.39 bindings foreman-packaging#9957
• Update katello-repos to use Pulpcore 3.39 foreman-packaging#9989

[ianballou]

I've also made it so the pulpcore module is not installed unless the pulpcore version is between 3.16 and 3.39. I'm not 100% certain if I should add the second conditional like I did.

[ekohl]

I don't think this is right. The file will already be there if it is enabled and instead it will actually skip this step if it's enabled (which is true for upgrades).

Just for background:

# dnf module enable pulpcore:el8
# ls /etc/dnf/modules.d
pulpcore.module  python39.module
# dnf module disable pulpcore
# ls /etc/dnf/modules.d
pulpcore.module  python39.module
# cat /etc/dnf/modules.d/pulpcore.module
[pulpcore]
name=pulpcore
stream=
profiles=
state=disabled

Note that the enable part also enabled python39 but disable doesn't disable python. It looks like ansible-core has rebased to python3.11 (al least in CentOS Stream 8), but worth considering in the release notes.

[ekohl]

@evgeni any thoughts on using this for idempotency?

- name: 'Disable pulpcore:el8 module'
  command: dnf module disable -y pulpcore:el8
  args:
    removes: /etc/dnf/modules.d/pulpcore.module

- name: Delete pulpcore module
  file:
    path: /etc/dnf/modules.d/pulpcore.module
    state: absent

[evgeni]

This looks reasonable. The removes on the disable command is a "lie", but then you fix it up and things should be fine.

OTOH, we could also just remove the file, that's the only thing that carries the info about the module state.

[evgeni]

I went with remove only and updated the PR

[evgeni]

https://github.com/theforeman/foreman-operations-collection/blob/develop/roles/foreman_repositories/tasks/redhat-modules.yml#L23 will need updating too

[evgeni]

theforeman/foreman-operations-collection#142