Add condition for foreman-client-repo based on bats version #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odilhao
force-pushed
the
bats-client-4.11
branch
from
6446fff to
f2ee09e
Compare
evgeni
reviewed
Dec 7, 2023
| @@ -4,3 +4,6 @@ | |||
| name: https://yum.theforeman.org/client/{{ foreman_client_repositories_version }}/{{ foreman_client_repositories_dists[ansible_os_family] }}{{ ansible_distribution_major_version }}/x86_64/foreman-client-release.rpm | |||
| disable_gpg_check: True | |||
| state: present | |||
| when: | |||
| - katello_repositories_version == "nightly" or foreman_client_repositories_version is version('3.9', '<') | |||
There was a problem hiding this comment.
katello_repositories_version is not necessarily defined in the client context.
There was a problem hiding this comment.
Yes, I pushed one after walking to get coffee and reflecting on my own mistakes
Odilhao
force-pushed
the
bats-client-4.11
branch
from
f2ee09e to
ceb46c4
Compare
evgeni
reviewed
Dec 7, 2023
| @@ -4,3 +4,6 @@ | |||
| name: https://yum.theforeman.org/client/{{ foreman_client_repositories_version }}/{{ foreman_client_repositories_dists[ansible_os_family] }}{{ ansible_distribution_major_version }}/x86_64/foreman-client-release.rpm | |||
| disable_gpg_check: True | |||
| state: present | |||
| when: | |||
| - foreman_client_repositories_version is version('3.9', '<') | |||
| - ansible_distribution_major_version == '8' | |||
There was a problem hiding this comment.
Copy past done wrong, let me clear that
Odilhao
force-pushed
the
bats-client-4.11
branch
2 times, most recently
from
8bada4f to
974ad95
Compare
Odilhao
force-pushed
the
bats-client-4.11
branch
from
974ad95 to
2c0f6de
Compare
|
I think this is wrong, we rather should set the staging_source correctly: #1745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix https://jenkins-foreman.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/foreman-pipeline-katello-rpm-4.11/detail/foreman-pipeline-katello-rpm-4.11/4/pipeline/94