Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipelines configuration for centos9-stream support #1842

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

archanaserver
Copy link
Contributor

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not very descriptive. When reading it I don't understand why this is being changed. The summary is also not very helpful.

When I start to look at it, I see the directory also has pipelines/vars/common/foreman_nightly_centos7.yml and pipelines/vars/common/katello_nightly_centos7.yml which makes me wonder: why do we keep those? And further, why do we even have these files? We've supported CentOS 9 for some time and the pipelines were passing.

I have some vague recollection @ehelms used these when manually testing and b62c9d9 (the commit that introduced it) doesn't show any code that actually uses it.

My advice would be to at least also remove CentOS 7 (which is also EOL) and come up with a better summary.

@ehelms
Copy link
Member

ehelms commented Aug 20, 2024

These are nice to haves, that I use to this day, so that I do not have to remember what all the variables are and what to type out locally, e.g.

ansible-playbook pipelines/install_pipeline.yml -e @pipelines/vars/common/katello_nightly_centos_stream9.yml

@archanaserver archanaserver changed the title Update configuration file Update pipelines configuration for centos9-stream support Aug 27, 2024
@ekohl ekohl merged commit 4d1a9f2 into theforeman:master Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants