Fix error with devel install from erroneuous Rubocop fix

[ehelms]

No description provided.

[daviddavis]

Do you want this to return true when $CHILD_STATUS is nil? I ask because previously ($CHILD_STATUS == 0) it would return false for nil.

[stbenjam]

Why not just $?.success?

[ehelms]

Updated based on @stbenjam suggestion

[stbenjam]

Lol sorry, rubocop doesn't like it, but I think rubocop's suggestion is bad and maybe we can just turn it off.

1.8.7-head :007 > system('ls')
[...snip...]
1.8.7-head :008 > $CHILD_STATUS.success?
NoMethodError: undefined method `success?' for nil:NilClass
    from (irb):8
    from /usr/bin/irb:11:in `<main>'
1.8.7-head :009 > $?.success?
 => true 

[ehelms]

Let's see if its happy now...

[stbenjam]

ACK

[daviddavis]

Looks like this is caused by not requiring 'English'. See here:

rubocop/rubocop#1747

[5] pry(main)> require 'English'
=> true
[6] pry(main)> system('ls')
[...]
[7] pry(main)> $CHILD_STATUS.success?
=> true

[stbenjam]

I still prefer $?

[daviddavis]

Yea, I think $? is clear because I see it so much in the terminal. However, some of the others like $', $;, etc, I would have to look up. I wish rubocop would let you whitelist particular ones though like $?. I wouldn't mind disabling this cop.

[ehelms]

Good to merge this as is? I'll most likely be turning a lot of this into
roles and playbooks so it shouldn't be around for too long.

On Aug 1, 2016 12:54 PM, "David Davis" notifications@github.com wrote:

I think $? is clear because I see it so much in the terminal. However,
some of the others like $', $;, etc, I would have to look up
http://ruby-doc.org/stdlib-2.0.0/libdoc/English/rdoc/English.html. I
wish rubocop would let you whitelist particular ones though like $?. I
wouldn't mind disabling this rubocop.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#266 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAR585lA8NaKgQNak-vN3MD5gr3F8crhks5qbiSzgaJpZM4JXveU
.

[daviddavis]

ACK from me.