Fixes #12472 - compute resource specific details in host help #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstrachota
force-pushed
the
extended_help_12472
branch
from
24f519d to
c1447cf
Compare
|
[test] |
mbacovsky
suggested changes
Nov 3, 2016
| module CommonUpdateHelp | ||
| def self.included(base) | ||
| base.extend_help do |h| | ||
| h.section 'Available keys for --interface' do |h| |
| ['provision', 'true/false'], | ||
| ['virtual', 'true/false'] | ||
| ]) | ||
| h.section 'For virtual=true' do |h| |
| ['attached_to', _('Identifier of the interface to which this interface belongs, e.g. eth1.')] | ||
| ]) | ||
| end | ||
| h.section 'For type=bond' do |h| |
| 'bond_options' | ||
| ]) | ||
| end | ||
| h.section 'For type=bmc' do |h| |
| end | ||
| end | ||
|
|
||
| h.section 'Provider specific options' do |h| |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@mbacovsky updated |
mbacovsky
approved these changes
Nov 3, 2016
|
👍 Looks ggot to merge now, thanks @tstrachota! 🐩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires theforeman/hammer-cli#222
ComputeResourcesfor compute resource specific behaviour, the file structure counts with adding more extension types in future (http://projects.theforeman.org/issues/4593, http://projects.theforeman.org/issues/10311, http://projects.theforeman.org/issues/3651, ...)Hosts