Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12189 - hammer report info doesn't show logs resources and mes… #375

Conversation

bjoernneumann
Copy link
Contributor

Source and Message will show something now when shown with hammer report info --id= instead of

  1. Resource:
    Message:

@theforeman-bot
Copy link
Member

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@mbacovsky
Copy link
Member

@bjoernneumann, thank you for the contribution, it is appreciated!

Recently the report.rb was renamed to config_report.rb to match the changes in the API. Your patch looks good to be merged, would you mind to move it to the new location so that it could be tested and merged?

@bjoernneumann bjoernneumann force-pushed the report-print-log-source-and-message branch from dd6ba49 to 4366504 Compare July 28, 2018 16:31
@bjoernneumann
Copy link
Contributor Author

@mbacovsky Done

@mbacovsky
Copy link
Member

👍 @bjoernneumann, perfect! Thanks for the update. Merging.

@mbacovsky mbacovsky merged commit c3c8fa2 into theforeman:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants