Refs #27868 - Fix method typo #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make the tests green we need to resolve #443 |
|
The patch looks good and it works as expected. The failing tests are unrelated. |
ofedoren
force-pushed
the
refs-27868-typ-par-opt
branch
from
bebb094 to
b9efe7e
Compare
|
@mbacovsky, thanks. I've added a test. |
|
Looks like the test failures are related, this is now failing in the nightly pipeline: https://ci.theforeman.org/job/hammer-cli-foreman-master-source-release/41/ |
shiramax
pushed a commit
that referenced
this pull request
Nov 18, 2019
(cherry picked from commit d7e3a79)
shiramax
pushed a commit
that referenced
this pull request
Nov 18, 2019
(cherry picked from commit d7e3a79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also be cherry-picked to 0.18-stable, so we can release 0.18.2.