-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #28135 - Remove URL field from GCE info #466
Refs #28135 - Remove URL field from GCE info #466
Conversation
Before: After: I haven't tested vmware, ec2, ovirt and rackspace - but openstack and libvirt show url correctly and given they all use the same code, I do not see a reason why the rest of the compute resources would not show the field properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofedoren the fix looks good to me, however, this change will no reflect in the API, is there a possibility to change the zone to URL in the API?
@shiramax, I think we could stop including |
@kgaikwad, sure, if nobody has concerns, it's ready. |
@shiramax, This change should be also cherry-picked into 0.19-stable. |
@kgaikwad, I think we need a CP for this into 0.19-stable. Do you want to do it or should I? |
@ofedoren, |
(cherry picked from commit 3d24c11)
This should be also cherry-picked into 0.19-stable for 0.19.5.