Unpin mocha version & fix deprecation warning #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
@floehopper Thanks, could you please prepend "Fixes #28420" to the commit message, then https://projects.theforeman.org/issues/28420 will be correctly handled. |
The regression introduced in mocha v1.10.0 which led to its version being pinned to v1.9.0 was fixed in mocha v1.11.2 which is currently the latest version, so it is nowsafe to unpin the version. Requiring 'mocha/setup' was deprecated in v1.10.0, so I've also fixed that with the change to `test/test_helper.rb`.
floehopper
force-pushed
the
unpin-mocha-dependency
branch
from
bc8caab to
70f1066
Compare
Done & force-pushed. |
shiramax
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression introduced in mocha v1.10.0 which led to its version being pinned to v1.9.0 was fixed in mocha v1.11.2 which is currently the latest version, so it is now safe to unpin the version.
Requiring 'mocha/setup' was deprecated in v1.10.0, so I've also fixed that with the change to
test/test_helper.rb.Fixes Redmine issue 28420.