Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minitest deprecation #523

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Fix minitest deprecation #523

merged 2 commits into from
Jun 25, 2020

Conversation

shiramax
Copy link
Contributor

No description provided.

@shiramax shiramax force-pushed the fix_minitest_deprication branch from 657c1fb to 222eb93 Compare June 1, 2020 18:36
@shiramax shiramax force-pushed the fix_minitest_deprication branch from 222eb93 to a19b44a Compare June 23, 2020 10:28
@ofedoren
Copy link
Member

@shiramax, this needs rebase :(

@shiramax shiramax force-pushed the fix_minitest_deprication branch from a19b44a to 2353430 Compare June 23, 2020 15:24
ofedoren
ofedoren approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shiramax for such punctilious job! 🌹

@ofedoren ofedoren merged commit f5668d1 into theforeman:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiramax @ofedoren @theforeman-bot