Fixes #30814 - change --owner_type's default to user #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @adiabramovitch! Can we add just a few tests to ensure we don't break this in the future? |
adiabramovitch
force-pushed
the
30814_new
branch
2 times, most recently
from
c3b3791 to
90e68a4
Compare
ofedoren
reviewed
Mar 29, 2021
|
|
||
| expected_result = success_result("Host created.\n") | ||
|
|
||
| result = run_cmd(cmd + minimal_params_without_hostgroup) |
There was a problem hiding this comment.
As far as I see we don't pass --owner option here, so onwer_id is not being called, thus the test doesn't actually tests the functionality of that method.
adiabramovitch
force-pushed
the
30814_new
branch
from
90e68a4 to
a6319f9
Compare
adiabramovitch
force-pushed
the
30814_new
branch
from
a6319f9 to
2ad424e
Compare
ofedoren
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.