Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6935 - Use the tty for the interactive output #289

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fixes #6935 - Use the tty for the interactive output #289

merged 1 commit into from
Oct 23, 2018

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented Oct 3, 2018

Removed return false unless tty? because of a case when we need to ask for password interactively regardless of STDOUT redirection.

Hammer.interactive_output should be used when there is a need to print something regardless of STDOUT redirection.

@ofedoren ofedoren mentioned this pull request Oct 3, 2018
Merged
mbacovsky
mbacovsky approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@mbacovsky mbacovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofedoren, looks good. It works fine with the patch in the foreman plugin. Thank you!

@mbacovsky mbacovsky merged commit e0ee4be into theforeman:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbacovsky mbacovsky mbacovsky approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofedoren @mbacovsky @theforeman-bot