Refs #7451 - allow skipping message tests

[tstrachota]

No description provided.

[ofedoren]

I think we could extend the checking process somehow, see the inline comment.

[ofedoren]

This will skip the whole command, but what if we want to skip checking the success message only and be sure that description hasn't a period at the end?

I'd suggest some changes:

  def check_command_messages(cmd, except = nil)
    except ||= []
    cmd.recognised_options.each do |opt|
      check_option_description(cmd, opt)
    end
    # we could skip checking only particular messages from a command
    refute_msg_period(cmd, :desc) unless except.include?(:desc)
    assert_msg_period(cmd, :success_message) unless except.include?(:success_message)
    refute_msg_period(cmd, :failure_message) unless except.include?(:failure_message)
  end

  def check_all_command_messages(main_cmd, parent = HammerCLI::AbstractCommand, opts = {})
    except = opts[:except] || {}

    all_subcommands(main_cmd, parent).each do |cmd|
      # skip the whole command if nothing particular was specified
      next if except.key?(cmd.to_s) && except[cmd.to_s].empty?
      it "test messages of #{cmd}" do
        check_command_messages(cmd, except[cmd.to_s])
      end
    end
  end

Those changes would lead to changes in theforeman/hammer-cli-foreman#352 as:

  check_all_command_messages(
    HammerCLI::MainCommand,
    HammerCLIForeman::Command,
    except: {
      'HammerCLIForeman::PersonalAccessToken::CreateCommand' => [:success_message]
    }
  )

[mbacovsky]

@tstrachota what do you think about keyword argument for except?

[tstrachota]

@mbacovsky @ofedoren updated

[ofedoren]

@tstrachota, works nice, I've got nothing to add :)

[mbacovsky]

👍 Thanks @tstrachota, @ofedoren