Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for import/export #13

Merged
merged 3 commits into from
Oct 21, 2016
Merged

Add support for import/export #13

merged 3 commits into from
Oct 21, 2016

Conversation

stbenjam
Copy link
Member

No description provided.

@stbenjam
Copy link
Member Author

@iNecas Do you know why Apipie isn't capturing the example from my export test? The test works, and calls export correctly:

https://github.com/theforeman/foreman_remote_execution/blob/master/test/functional/api/v2/job_templates_controller_test.rb#L73-L77

But the examples don't include the response so tests will fail here

  "job_templates#export": [
    {    
      "verb": "GET",
      "path": "/api/job_templates/1007981745-Job%20template%2043/export",
      "versions": [
        "v2"
      ],   
      "query": "",
      "request_data": null,
      "response_data": null,
      "code": "200",
      "show_in_doc": 1,
      "recorded": true 
    }  

@stbenjam
Copy link
Member Author

Reason is this Apipie/apipie-rails#453

@iNecas
Copy link
Member

iNecas commented Oct 13, 2016

I've merged and released new apipie-rails version with the fix. Could you update the docs json now? Sry for the awful delay with this.

Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this patch and works well! APT

@adamruzicka
Copy link
Contributor

Looks like there's some version pinning needed for 1.9.3

@adamruzicka
Copy link
Contributor

On my machine this still fails on 1.9.3, this should be fixed by Apipie/apipie-bindings#51

@stbenjam
Copy link
Member Author

With a clean gemset? Works fine for me...

 stbenjam  ~  git  hammer_cli_foreman_remote_execution  gem install bundler; bundle install                                                                                                     1   export 
Fetching: bundler-1.13.5.gem (100%)
Successfully installed bundler-1.13.5
Installing ri documentation for bundler-1.13.5
1 gem installed
Fetching gem metadata from https://rubygems.org/...........
Fetching version metadata from https://rubygems.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies...
Installing rake 10.1.1
Installing json 1.8.3 with native extensions
Installing oauth 0.5.1
Installing unf_ext 0.0.7.2 with native extensions
Installing mime-types 2.99.1
Installing netrc 0.11.0
Installing awesome_print 1.6.1
Installing builder 3.2.2
Installing clamp 1.0.0
Installing docile 1.1.5
Installing fast_gettext 1.0.0
Installing locale 2.1.2
Installing text 1.3.1
Installing highline 1.7.8
Installing little-plugger 1.1.4
Installing multi_json 1.11.2
Installing table_print 1.5.6
Installing hashie 3.4.3
Installing metaclass 0.0.4
Installing minitest 4.7.3
Installing minitest-spec-context 0.0.3
Installing simplecov-html 0.10.0
Installing thor 0.19.1
Using bundler 1.13.5
Installing unf 0.1.4
Installing ci_reporter 1.9.3
Installing gettext 3.2.1
Installing logging 2.1.0
Installing powerbar 1.0.17
Installing mocha 1.1.0
Installing simplecov 0.11.2
Installing domain_name 0.5.20160310
Installing http-cookie 1.0.2
Installing rest-client 1.8.0
Installing apipie-bindings 0.0.16
Installing hammer_cli 0.6.1
Installing hammer_cli_foreman 0.6.2
Installing hammer_cli_foreman_tasks 0.0.10
Using hammer_cli_foreman_remote_execution 0.0.5 from source at `.`
Bundle complete! 11 Gemfile dependencies, 39 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 21, 2016

It's green. hammer-cli-foreman dropped 1.9.3 which was the other error. It all runs on distros that 2.0 in SCL or system ruby anyway.

Is there any reason to try to keep 1.9.3? I don't think it'll even work with the dep on hammer-cli-foreman.

@iNecas
Copy link
Member

iNecas commented Oct 21, 2016

Thanks @stbenjam! You're right, there is no reason for keeping some extra version to hammer-cli-foreman

@iNecas iNecas merged commit 9f69bfa into theforeman:master Oct 21, 2016
@stbenjam stbenjam deleted the export branch October 21, 2016 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants