-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.0 + Puppet 7 & 3.2 + Puppet 8 to CI #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want to keep testing on the old versions, just add the new versions.
f2a2333
to
b4b5293
Compare
39721f9
to
65edc6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of [WIP]
you can also mark the PR as a draft (https://github.blog/2019-02-14-introducing-draft-pull-requests/).
65edc6c
to
cd67282
Compare
The tests execute now and the failure is related. The internal kafo configure Module is not marked as compatible with Puppet 8: kafo/modules/kafo_configure/metadata.json Line 12 in e8d1a1e
Not sure if just bumping this would be sufficient, but certainly worth a try |
cd67282
to
9e99a54
Compare
What do you mean by "on the previous changes"? The ones before you pushed today? You can see previous runs in https://github.com/theforeman/kafo/actions And they did not skip the "Tests" part, as there "Rubocop" succeeded. Seems Rubocop 1.59 is rather new (https://github.com/rubocop/rubocop/releases/tag/v1.59.0) and triggers those errors. We should archive the |
9e99a54
to
bdc6625
Compare
I can't see this rubocop failure in my local, also i just remembered that i've already fix these two cops here https://github.com/theforeman/kafo/blob/master/.rubocop.yml#L156-L160, don't know why it is failing here? |
This is what fixed the cops erroring for me:
|
bdc6625
to
b216f7a
Compare
@ehelms thanks, i got it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One could argue this should be 3 commits ("make code compliant with latest rubocop", "mark kafo_configure module as compatible with puppet 8" and "include Ruby 3 and Puppet 8 in test matrix"), but I am not going to nitpick here :)
Thank you for the review. |
Update Ruby ~> 3 and Puppet ~> 8