Refactor tests to not test private classes #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Oct 26, 2018
| @@ -1,5 +1,6 @@ | |||
| # Configuration for Candlepin | |||
| class candlepin::config { | |||
| assert_private() | |||
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-stdlib#assert_private is not that clear, but essentially if you include candlepin::config from another module (such as katello) it'll raise an error. I'm not entirely sure about the second commit. Maybe just marking it as @api private in the docs is enough (#117) but this way we can easily revert it.
ehelms
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.