-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candlepin service running via a systemd container #121
Conversation
ed586a3
to
e833edf
Compare
Current playbook to test this with existing open PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces please :)
bc42d54
to
9e4cfc6
Compare
8e754ca
to
13d2ec6
Compare
Updated |
eacec5b
to
6d6f946
Compare
6d6f946
to
12946fc
Compare
I moved the pull into the |
12946fc
to
40ca59c
Compare
40ca59c
to
2913364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 👍
2913364
to
f3d10b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is podman available on all platforms we support? Forgot Katello only supports EL7 based distributions, nevermind.
ExecStartPre=-/usr/bin/podman rm "candlepin-1" | ||
ExecStart=/usr/bin/podman run --name candlepin-1 --env-file /etc/sysconfig/candlepin --net host -v /etc/candlepin:/etc/candlepin:z -v /etc/tomcat:/etc/tomcat:z -p <%= scope['candlepin::ssl_port'] %> <%= scope['candlepin::container_image'] %>:<%= scope['candlepin::container_version'] %> | ||
ExecReload=-/usr/bin/podman stop "candlepin-1" | ||
ExecReload=-/usr/bin/podman rm "candlepin-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't reload be used for "make the service reload its configuration without stopping it" kind of thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you make any configuration changes on disk, or environment variables you have to stop the container and re-start to pick up the new. I could be wrong though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds more like restart and reload should simply not be implemented then.
This requires a few other changes to go in to work that have open PRs. The idea is to introduce a candlepin service that runs a container via podman. This introduces a new paramter to switch to this mode. One downside is that this creates two service paths: tomcat service and Candlepin service. I debated first migrating to a Candlepin service that starts tomcat for non-container installs so there is one service with two implementations but wanted to see what others thought first.
Dependent PRs: