Fixes #35699 - Introduce a parameter to configure logging #226
Conversation
| <%- unless 'org.candlepin' in $loggers { -%> | ||
|
|
||
| # uncomment to enable debug logging in candlepin.log: | ||
| #log4j.logger.org.candlepin=DEBUG |
There was a problem hiding this comment.
Do we want to keep this comment here that a user can't do anything with? Or would lead them astray?
There was a problem hiding this comment.
My reasoning was that it can help users who quickly want to debug, but I wasn't quite sure.
There was a problem hiding this comment.
I'd lean to drop to prevent the inevitable bug reports about this gets wiped out every time they run the installer and then having to explain they ought to use the installer itself.
@ehelms any idea about this? |
No direct knowledge, but it certainly reads like it was fixed and therefore should no longer be something we need to work around. Drop it. |
|
Looking at the ticket, it's said to be fixed in hibernate 5.4, and a Katello 4.5 that I have here has |
This also drops the Hibernate logger since it should have been resolved by now.
|
That greatly simplified the whole PR. |
| @@ -26,9 +26,9 @@ candlepin.ca_key_password=<%= scope['candlepin::ca_key_password_unsensitive'] %> | |||
| <%- end -%> | |||
|
|
|||
| candlepin.async.jobs.ExpiredPoolsCleanupJob.schedule=<%= scope['candlepin::expired_pools_schedule'] %> | |||
| <% if scope['candlepin::loggers'].any? -%> | |||
There was a problem hiding this comment.
I am surprised this any? is needed.
There was a problem hiding this comment.
Mostly for a visual separation with an empty line between the groups.
This came up via theforeman/foreman-documentation#1715 where there are instructions to manually configure this. The goal is that users don't touch individual files but rather use the installer to modify it.
I do wonder about https://hibernate.atlassian.net/browse/HHH-12927. It's been resolved for 4 years now so is it still needed?