Change existing Kafo type definitions to Puppet 4 types #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
stbenjam
changed the title
ekohl
approved these changes
Dec 16, 2016
ekohl
reviewed
Dec 16, 2016
| @@ -27,4 +27,9 @@ PuppetLintParamDocs.define_selective do |config| | |||
| config.pattern = ["manifests/capsule.pp", "manifests/init.pp"] | |||
| end | |||
|
|
|||
| require 'kafo_module_lint/tasks' | |||
| KafoModuleLint::RakeTask.new do |config| | |||
| config.pattern = ["manifests/capsule.pp", "manifests/init.pp"] | |||
There was a problem hiding this comment.
Should manifests/puppet.pp be included here as well? That should also be added to .sync.yml
|
This fixes an issue with nightlies so I'd like to get this merged. |
stbenjam
changed the title
|
Ready for another look. Puppet is not needed at the top level anymore, we did it a different way. |
|
Is the removal of capsule intentional? It feels like it doesn't belong in changing the kafo type definitions. Maybe at least make it a separate commit? |
ekohl
requested changes
Jan 9, 2017
| # | ||
| # $certs_tar:: path to tar file with certs to generate. REQUIRED | ||
| # $certs_tar:: Path to tar file with certs to generate |
There was a problem hiding this comment.
A bit odd that this is required but in the code there's if $certs_tar {.
There was a problem hiding this comment.
You're right, it is actually optional since you don't need the certs tar on a Katello. I updated the type
|
Ok ready for another look |
ekohl
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.