Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed tar option to determine the file is compressed or not #119

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

netman2k
Copy link
Contributor

certs::tar_extract always use -xzf option even though the file was not compressed.

When I run the command below, the foreman-installer fails due to this problem.

foreman-installer --scenario capsule --capsule-certs-tar /root/katello-httpd-ssl-archive-capsule01.example.net-1.0-10.tar --certs-update-all

please change the option.

@ehelms
Copy link
Member

ehelms commented Dec 28, 2016

Would you mind explaining the underlying issue a bit? The create command attempts to compress (https://github.com/Katello/puppet-certs/blob/master/manifests/tar_create.pp#L19) but you appear to have a certificate archive without compression?

@netman2k
Copy link
Contributor Author

I did odd things recently and found that the tar_extract.pp does not recognize well.
It's not possibly happened.

Basically, when we see the tar extension of a file, we do not think that it's compressed.
I'm not sure why the file name ends with tar not gz, but we can create a file like capsule-cert-generated generated.

That's why I wanted to change this code. I think it's better to understand.

@ehelms
Copy link
Member

ehelms commented Dec 29, 2016

thanks @netman2k

@ehelms ehelms merged commit 7020bf8 into theforeman:master Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants