Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #17572 - module works with master compile #127

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

timogoebel
Copy link
Member

This is currently untested using puppet apply.

@ehelms, @ekohl: Could you take a look please?

@timogoebel timogoebel force-pushed the 17572-fix-master-mode branch 2 times, most recently from da2249c to 3f16a77 Compare March 13, 2017 13:19
@timogoebel timogoebel force-pushed the 17572-fix-master-mode branch from 3f16a77 to 9e57646 Compare March 13, 2017 13:37
Copy link
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the puppet labs ticket, it looks like this workaround should be OK.

I tested this PR with the installer (puppet apply) and it was fine.

Would be good to get a second opinion on it from the others as well.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have very little experience writing types and providers, but I trust @timogoebel and the testing of @stbenjam so merging this.

@ekohl ekohl merged commit 9e57646 into theforeman:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants