Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an acceptance test for candlepin #145

Merged
merged 2 commits into from
Sep 19, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 23, 2017

This is how an acceptance test for candlepin could look like. Currently it doesn't pass yet and we should move more code into common areas to manage the repositories.

This includes #144, builds on Katello/foreman-installer-modulesync#20 and relates to theforeman/puppet-pulp#164.

@ekohl ekohl force-pushed the candlepin-acceptance-tests branch 2 times, most recently from a8ee582 to 08fd976 Compare March 24, 2017 16:36
@ekohl
Copy link
Member Author

ekohl commented Mar 24, 2017

The acceptance tests now pass for me.

While trying to get a minimal set I also wanted to install candlepin without qpid. Since puppet-candlepin does support that I introduced a parameter to certs::candlepin to mirror this. I can submit this as a separate PR.

@ekohl ekohl force-pushed the candlepin-acceptance-tests branch from 08fd976 to 94d6bf8 Compare March 27, 2017 14:22
@ekohl ekohl changed the title [WIP] Add an acceptance test for candlepin Add an acceptance test for candlepin Mar 28, 2017
@ekohl ekohl force-pushed the candlepin-acceptance-tests branch from 94d6bf8 to ee3e930 Compare March 29, 2017 02:00
@ekohl
Copy link
Member Author

ekohl commented Mar 29, 2017

Now with an actual API call to /candlepin/status. I only read the API documentation and assumed this is the correct way to check if it's up and correctly initialized. It would be great if someone could confirm that.

@sean797
Copy link
Member

sean797 commented Jun 15, 2017

/candlepin/status looks right to me, though I don't really know. This requires a rebase now..

Thanks for doing this BTW @ekohl 🥇

@ekohl
Copy link
Member Author

ekohl commented Jun 15, 2017

I think I'll first try and finish the acceptance test for candlepin itself and then revisit this. Maybe the more modular puppet-katello would be a better place to test with certificates.

@ekohl ekohl changed the title Add an acceptance test for candlepin [WIP] Add an acceptance test for candlepin Aug 24, 2017
@ekohl
Copy link
Member Author

ekohl commented Aug 24, 2017

Marking it as WIP for now.

@ekohl ekohl force-pushed the candlepin-acceptance-tests branch from ee3e930 to af769ae Compare August 30, 2017 15:02
@ekohl ekohl force-pushed the candlepin-acceptance-tests branch from af769ae to 729f5d7 Compare September 7, 2017 20:11
@ekohl ekohl force-pushed the candlepin-acceptance-tests branch from 729f5d7 to 5383c4b Compare September 14, 2017 11:56
@ekohl ekohl changed the title [WIP] Add an acceptance test for candlepin Add an acceptance test for candlepin Sep 14, 2017
@ekohl
Copy link
Member Author

ekohl commented Sep 14, 2017

Rebased it and now it verifies just that the files exist with the correct content. This will be the basis for verification on replacing the execs with puppetlabs-java_ks.

@ehelms ehelms merged commit f4152fa into theforeman:master Sep 19, 2017
@ekohl ekohl deleted the candlepin-acceptance-tests branch September 19, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants