-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an acceptance test for candlepin #145
Conversation
a8ee582
to
08fd976
Compare
The acceptance tests now pass for me. While trying to get a minimal set I also wanted to install candlepin without qpid. Since puppet-candlepin does support that I introduced a parameter to certs::candlepin to mirror this. I can submit this as a separate PR. |
08fd976
to
94d6bf8
Compare
94d6bf8
to
ee3e930
Compare
Now with an actual API call to |
Thanks for doing this BTW @ekohl 🥇 |
I think I'll first try and finish the acceptance test for candlepin itself and then revisit this. Maybe the more modular puppet-katello would be a better place to test with certificates. |
Marking it as WIP for now. |
ee3e930
to
af769ae
Compare
af769ae
to
729f5d7
Compare
729f5d7
to
5383c4b
Compare
Rebased it and now it verifies just that the files exist with the correct content. This will be the basis for verification on replacing the execs with puppetlabs-java_ks. |
This is how an acceptance test for candlepin could look like. Currently it doesn't pass yet and we should move more code into common areas to manage the repositories.
This includes #144, builds on Katello/foreman-installer-modulesync#20 and relates to theforeman/puppet-pulp#164.