Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19271 - reload docker instead of restart #156

Merged
merged 1 commit into from
May 25, 2017

Conversation

ahumbe
Copy link
Contributor

@ahumbe ahumbe commented May 2, 2017

Restarting docker service will stop all the running containers, so instead of restart we should reload the service which will not affect any running container.

@ahumbe
Copy link
Contributor Author

ahumbe commented May 2, 2017

As a part of installation of katello-ca-consumer package we do not make any changes to the existing docker configuration, can any one help me understand why need to restart/reload the docker service?

@ekohl
Copy link
Member

ekohl commented May 2, 2017

Interesting. In #155 @stbenjam said there was no reload.

@ahumbe
Copy link
Contributor Author

ahumbe commented May 2, 2017

The reload option is there for the docker service, here is the output :

  • service docker reload
    Redirecting to /bin/systemctl reload docker.service

  • tail -f /var/log/messages
    May 2 10:39:53 rhel7u2-2 dockerd-current: time="2017-05-02T10:39:53.184676367-04:00" level=info msg="Got signal to reload configuration, reloading from: /etc/docker/daemon.json"
    May 2 10:39:53 rhel7u2-2 dockerd-current: time="2017-05-02T10:39:53.185286790-04:00" level=error msg="open /etc/docker/daemon.json: no such file or directory"
    May 2 10:39:53 rhel7u2-2 systemd: Reloaded Docker Application Container Engine.

@ekohl
Copy link
Member

ekohl commented May 2, 2017

I assume @stbenjam is busy with Summit right now but I'd like his opinion on this.

@ahumbe ahumbe force-pushed the 19271_docker_reload branch from 590cb57 to 289511c Compare May 5, 2017 12:48
@stbenjam
Copy link
Member

I get an error on my box when I try reload but I guess it was added in 2015 and seems there on a fresh install on CentOS 7. So this should be OK

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a trivial rebase Travis should be happy too.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from me too

@ekohl ekohl merged commit 8251720 into theforeman:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants