Fixes #20642 - don't set hostname-override when localhost #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Aug 18, 2017
| if [ $? == "0" ] && [ -d /etc/rhsm/facts/ ]; then | ||
| echo "{\"network.hostname-override\":\"$FQDN\"}" > /etc/rhsm/facts/katello.facts | ||
| if [ $? == "0" ] && [ "$FQDN" != "localhost" ] && [ -d /etc/rhsm/facts/ ]; then | ||
| echo "{\"network.hostname-override\":\"$FQDN\"}" > /etc/rhsm/faacts/katello.facts |
There was a problem hiding this comment.
I doubt this line was intentional.
There was a problem hiding this comment.
Daaamn :) Fixed. Thanks for spotting this. My future that would need to debug the issue in few years also thanks you :)
ekohl
approved these changes
Aug 19, 2017
|
@ehelms anything else required for this PR, or it can be merged? |
ehelms
approved these changes
Aug 30, 2017
There was a problem hiding this comment.
@iNecas This will fix the issue for new clients, but without a change in Katello as well this won't prevent existing clients from running into this problem. I think we should file a separate issue or consider this one not fixed until that part is done as well.
|
Here is the issue against Katello http://projects.theforeman.org/issues/20816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.