Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify variable access #165

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Simplify variable access #165

merged 1 commit into from
Aug 30, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 21, 2017

This should effectively be no change.

@ekohl
Simplify variable access
1245256 
This should effectively be no change.
@ekohl ekohl requested a review from ehelms August 26, 2017 21:52
@sean797
Copy link
Member

sean797 commented Aug 29, 2017

I'm not sure if you want to do something similar to default_ca_name in https://github.com/Katello/puppet-certs/blob/master/manifests/candlepin.pp#L127 ?

@ekohl ekohl merged commit 435754e into theforeman:master Aug 30, 2017
@ekohl ekohl deleted the simplify branch August 30, 2017 13:33
@ekohl
Copy link
Member Author

ekohl commented Aug 30, 2017

@sean797 I'll look into that.

@ekohl
Copy link
Member Author

ekohl commented Aug 30, 2017

@sean797 that looks like a good candidate but I'm working on using puppetlabs-java_ks to replace the execs. I'll fix that as well then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @sean797 @ehelms