Drop apache username/password #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
changed the title
|
Rebased, now with acceptance test. |
chris1984
approved these changes
Sep 7, 2017
sean797
reviewed
Sep 13, 2017
| cert_file => $apache_cert, | ||
| notify => Service['httpd'], |
There was a problem hiding this comment.
I'd rather solve this at another layer, namely puppet-katello and puppet-foreman_proxy_content where we apply this. The benefit is that this class becomes totally self-contained. theforeman/puppet-foreman_proxy_content#138 should be merged before though. In particular theforeman/puppet-foreman_proxy_content@199b334
There was a problem hiding this comment.
Okay, lets merge the other one first 👍 I'll review it later today.
sean797
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces coupling to other modules and will allow much easier testing while increasing security.
Apache uses the root user to read certificates and private keys so we can tighten the permissions to
root:root 0640.In puppet-katello we already subscribe to it here and that is equal.
In puppet-foreman_proxy_content we subscribe to it here but I'm not 100% sure yet if this is equal. Ordering should be correct but if Apache is actually reloaded is not guaranteed. theforeman/puppet-foreman_proxy_content#136 will fix this.