candlepin: remove nssdb dependency #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was a bit unsure about this in the first place and agree with your reasoning but I hadn't looked far enough into this to check why it's there in the first place. |
ekohl
approved these changes
Oct 4, 2017
|
Oh, and I think https://github.com/Katello/puppet-certs/blob/f4152faff300dbd1ff972e5575e3934e4a8f9a98/spec/acceptance/candlepin_spec.rb#L24-L26 can be removed because of this. |
|
@ekohl did you check that the Candlepin listener event is happy and receiving events? |
|
@ehelms if it's covered by bats then yes, otherwise no. |
timogoebel
force-pushed
the
candlepin_certs
branch
from
8780977 to
e9c1f09
Compare
|
Removed |
sean797
approved these changes
May 18, 2018
|
Thanks @timogoebel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reasoning for this code being there. Basically, it adds candlepin's
java-clientcert (the cert candlepin uses to connect to qpidd) to the qpidd truststore.Candlepin doesn't need this to boot up. And it doesn't need this to connect to qpidd. We don't do anything similar elsewhere. I mean, isn't the idea of a PKI to not whitelist individual certificates but trust the CA?
Anyways, this removes another dependency. Goes along with theforeman/puppet-katello#215 to remove the qpidd dependency.