Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21873 - Add validation for proxy fqdn #186

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Fixes #21873 - Add validation for proxy fqdn #186

merged 1 commit into from
Dec 7, 2017

Conversation

chris1984
Copy link
Member

No description provided.

@chris1984 chris1984 requested a review from ekohl December 5, 2017 15:52
ekohl
ekohl approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how many people actually read the warnings but it doesn't hurt.

@chris1984 chris1984 merged commit 87bf159 into theforeman:master Dec 7, 2017
@chris1984 chris1984 deleted the validate branch December 7, 2017 16:25
@ekohl ekohl mentioned this pull request Jan 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris1984 @ekohl @theforeman-bot