Fixes #4650 - consumer cert alias for katello #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ | |||
| $candlepin_consumer_name = "${$certs::default_ca_name}-consumer-${::fqdn}" | |||
| $candlepin_consumer_summary = "Subscription-manager consumer certificate for Katello instance ${::fqdn}" | |||
| $candlepin_consumer_description = 'Consumer certificate and post installation script that configures rhsm.' | |||
| $candlepin_cert_rpm_alias = "${$certs::default_ca_name}-consumer-latest.noarch.rpm" | |||
There was a problem hiding this comment.
What about making this a parameter in this class while we are at it, just so it's overridable if we want to set it ourselves?
There was a problem hiding this comment.
@ehelms updated, made the cert alias a parameter for the class.
|
ACK pending Travis |
|
@ehelms could this be an issue with puppet-lint? |
|
@ehelms nvm previous comment, found this http://puppet-lint.com/checks/class_parameter_defaults/ |
Consumer cert alias stored as a variable so that puppet_katello can use the cert name in the katello.yml template.
|
@ehelms updated, because puppet-lint complaining about derived default values for class parameters. |
|
ACK. @dustint-rh thanks! Merging. |
ehelms
added a commit
that referenced
this pull request
Jun 26, 2014
Fixes #4650 - consumer cert alias for katello
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer cert alias stored as a variable so that puppet_katello can use
the set the cert name in the katello.yml template.