Add "set -e" to consumer script #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jan 25, 2018
| order => '01', | ||
| } | ||
|
|
||
| concat::fragment { "${title}+default_ca_data": | ||
| target => $title, | ||
| content => "read -r -d '' KATELLO_DEFAULT_CA_DATA << EOM\n", | ||
| content => "read -r -d '' KATELLO_DEFAULT_CA_DATA << EOM || true\n", |
There was a problem hiding this comment.
I think, every time. Do not know why, though
root@steve-ratzloff:~# read -d '' -r TEST << EOF
> asdf
> EOF
root@steve-ratzloff:~# echo $TEST $?
asdf 1
There was a problem hiding this comment.
You're right: from man read:
The exit status is zero, unless end-of-file is encountered
There was a problem hiding this comment.
Thanks for diving into this.
But now i remember, that is why while read LINE works.
ekohl
approved these changes
Jan 25, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you want this, but whenever this option is not set for a shell script, i loose days searching for the line where something failed.