Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not let foreman_proxy_content inherit from params #214

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Do not let foreman_proxy_content inherit from params #214

merged 1 commit into from
Sep 26, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 14, 2018

No description provided.

@ekohl ekohl mentioned this pull request Sep 14, 2018
Closed
chris1984
chris1984 approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 for being able to soon have split deployments.

@ekohl ekohl merged commit e331477 into theforeman:master Sep 26, 2018
@ekohl ekohl deleted the no-inherit branch September 26, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @chris1984 @theforeman-bot