Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the file is present in tar_extract #230

Merged
merged 2 commits into from
Dec 4, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 26, 2018

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Nov 26, 2018

FYI: I intend to use rspec mocks in all modules and will modulesync that.

@ekohl
Copy link
Member Author

ekohl commented Dec 3, 2018

I'm leaning to merging this as it is now. Currently it's still a redundant check and the docs are in the installer.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl feel free to merge.

@ekohl ekohl merged commit d54cadf into theforeman:master Dec 4, 2018
@ekohl ekohl deleted the check-file-presence branch December 4, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants