Add nssdb files for EL8 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Feb 20, 2019
ehelms
force-pushed
the
add-more-nssdb
branch
2 times, most recently
from
eca978a to
45c925e
Compare
evgeni
approved these changes
Feb 21, 2019
ekohl
reviewed
Feb 21, 2019
manifests/ssltools/nssdb.pp
Outdated
| @@ -6,7 +6,15 @@ | |||
| Exec { logoutput => 'on_failure' } | |||
|
|
|||
| $nss_db_password_file = "${nss_db_dir}/nss_db_password-file" | |||
| $nssdb_files = ["${nss_db_dir}/cert8.db", "${nss_db_dir}/key3.db", "${nss_db_dir}/secmod.db"] | |||
|
|
|||
| case $facts['operatingsystemmajrelease'] { | |||
There was a problem hiding this comment.
I think I agree with @evgeni that we should be future compatible. How about:
$nssdb_files = $facts['operatingsystemmajrelease'] ? {
'7' => ["${nss_db_dir}/cert8.db", "${nss_db_dir}/key3.db", "${nss_db_dir}/secmod.db"],
default => ["${nss_db_dir}/cert9.db", "${nss_db_dir}/key4.db", "${nss_db_dir}/pkcs11.txt"],
}
ehelms
force-pushed
the
add-more-nssdb
branch
from
45c925e to
c62557f
Compare
|
Updated to change the default |
ekohl
approved these changes
Feb 21, 2019
ehelms
force-pushed
the
add-more-nssdb
branch
from
c62557f to
8cb2cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.