-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #29715: Add mongodb server and client certs #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind creating an acceptance test so it actually runs the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it fails because /etc/pulp
doesn't exist when it it tries to create the files.
Error: /Stage[main]/Certs::Mongodb/Certs::Keypair[mongodb_client]/Privkey[/etc/pulp/mongodb-client-certificate.key]/ensure: change from 'absent' to 'present' failed: Could not set 'present' on ensure: No such file or directory @ rb_sysopen - /etc/pulp/mongodb-client-certificate.key (file: /etc/puppetlabs/code/environments/production/modules/certs/manifests/keypair.pp, line: 18)
This is also very likely going to be a problem when you deploy them because the class is usually set up to first create certs and then deploy pulp.
d5af860
to
0e9a37e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be split in certs::mongodb::server
and certs::mongodb::client
. This will allow us to deploy just the client certs on a server without mongodb present.
I do appreciate the idea and power behind splitting, this class is intended for a rather specific purpose and will be short lived as Pulp 2 is not long left of life in our ecosystem. I prefer to keep this is together and simple. |
My reasoning is that we will need them in Pulpcore to import. There the parameters ( |
8fa8aa0
to
99b9973
Compare
d70e910
to
83c38c0
Compare
ffdf4ec
to
26fc14e
Compare
Tis green now and split into two classes. |
@ekohl Ready for re-review please |
No description provided.