Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30312: Drop docker, atomic and goferd support from consumer RPM #289

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jul 2, 2020

@jlsherrill @parthaa Could y'all confirm that these can safely be removed for Katello 4.0 and point to anything else that might could be removed? I left in the EL5 host override fact for now given EL5 EOLs in November of this year which more closely aligns with 4.1.

@ehelms ehelms changed the title Fixes #30313: Drop docker, atomic and goferd support from consumer RPM Fixes #30312: Drop docker, atomic and goferd support from consumer RPM Jul 2, 2020
@jturel
Copy link
Contributor

jturel commented Jul 7, 2020

Looks sane to me

@parthaa
Copy link
Contributor

parthaa commented Jul 7, 2020

I am ok with the changes here. But have a question -> 3028e1f meant for atomic changed a bunch of things .

  • It created a new katello-rhsm-reconfigure script (may have the wrong name)
  • It required the cert to be embedded in the reconfigure script

Wonder if we should take the approach of splitting certs into a separate file since this kinda hack is no longer necessary.
I am a bit conflicted about this though. Ok with what is there.

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2020

@parthaa you are sniffin around changes I plan to make as a follow up to simplify things. I want to clean up any unsupported workflows, then move creation to a different module (theforeman/puppet-foreman_proxy_content#272) and then further re-factor to simplify the script and drop the reliance on katello-certs-tools.

@parthaa
Copy link
Contributor

parthaa commented Jul 7, 2020

@parthaa you are sniffin around changes I plan to make as a follow up to simplify things. I want to clean up any unsupported workflows, then move creation to a different module (theforeman/puppet-foreman_proxy_content#272) and then further re-factor to simplify the script and drop the reliance on katello-certs-tools.

sounds good to me! ACK from my perspective

@ehelms ehelms merged commit c68c1c8 into theforeman:master Jul 7, 2020
@ekohl
Copy link
Member

ekohl commented Jul 10, 2020

@ehelms I think this would be a major version change, right?

@ehelms
Copy link
Member Author

ehelms commented Jul 10, 2020

Yes - since this will correspond with the Pulp 2 removal and Katello 4.0 effort.

@ehelms
Copy link
Member Author

ehelms commented Jul 10, 2020

This change is already captured in theforeman/puppet-foreman_proxy_content#272 as well

@ekohl
Copy link
Member

ekohl commented Jul 10, 2020

Right, labeled it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants