Introduce nssdb and nssdb_certificate types #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbclark
reviewed
Jun 19, 2021
spec/support/acceptance/nssdb.rb
Outdated
|
|
||
| def command_result | ||
| @command_result ||= @runner.run_command(command) | ||
| end |
There was a problem hiding this comment.
Does this need a command_result method? What is unique to Nssdb that can't be inherited from Command?
There was a problem hiding this comment.
Because the default implementation calls @name. I've submitted mizzy/serverspec#616 which would make this easier.
ekohl
commented
Jun 24, 2021
spec/support/acceptance/nssdb.rb
Outdated
| class Nssdb < Command | ||
| def certificates | ||
| # TODO: parse the output | ||
| command_result |
There was a problem hiding this comment.
Note to self: this should probably be
Suggested change
| command_result | |
| stdout |
These are more expressive of what to match.
|
Given these will be removed when Qpid support is dropped, I'm opting to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are more expressive of what to match.
Very incomplete, just as a way to describe the layout and design.