Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #9392 - pass options to foreman-rake config command correctly #52

Merged
merged 1 commit into from
Feb 20, 2015

Conversation

stbenjam
Copy link
Member

Reverts #50 - this doesn't actually work

[root@prometheus katello-installer]# foreman-rake config -k ssl_ca_file -v '/etc/foreman/proxy_ca.pem'      -k ssl_certificate -v '/etc/foreman/client_cert.pem'      -k ssl_priv_key -v '/etc/foreman/client_key.pem'
invalid option: -k

@elobato

@stbenjam
Copy link
Member Author

foreman-rake config -- -k ssl_ca_file -v '/etc/foreman/proxy_ca.pem' -k ssl_certificate -v '/etc/foreman/client_cert.pem' -k ssl_priv_key -v '/etc/foreman/client_key.pem' may do it (notice the extra --) and we might not need to revert...

@dustints
Copy link

ack!

@stbenjam
Copy link
Member Author

I'd rather fix it than revert, I don't know if the double dash will work with puppet, or if it will only work interactively. Needs to be tested, but I think this would fix it -

$foreman_config_cmd = "${::foreman::app_root}/script/foreman-rake config --\

@dustints
Copy link

testing

@dustints
Copy link

@stbenjam yup tested, that works too

DEBUG 2015-02-20 18:03:48 main]  Executing '/sbin/chkconfig foreman'
[DEBUG 2015-02-20 18:03:49 main]  Exec[foreman_certs_config](provider=posix): Executing check '/usr/share/foreman/script/foreman-rake config --      -k ssl_ca_file -v '/etc/foreman/proxy_ca.pem'      -k ssl_certificate -v '/etc/foreman/client_cert.pem'      -k ssl_priv_key -v '/etc/foreman/client_key.pem' --dry-run'
[DEBUG 2015-02-20 18:03:49 main]  Executing '/usr/share/foreman/script/foreman-rake config --      -k ssl_ca_file -v '/etc/foreman/proxy_ca.pem'      -k ssl_certificate -v '/etc/foreman/client_cert.pem'      -k ssl_priv_key -v '/etc/foreman/client_key.pem' --dry-run'
[DEBUG 2015-02-20 18:05:10 main]  /Stage[main]/Certs::Foreman/Exec[foreman_certs_config]/unless: Workaround for RbVmomi may not work as ComputeResource is already loaded: ComputeResource
[DEBUG 2015-02-20 18:05:10 main]  /Stage[main]/Certs::Foreman/Exec[foreman_certs_config]/unless: /etc/foreman/proxy_ca.pem
[DEBUG 2015-02-20 18:05:10 main]  /Stage[main]/Certs::Foreman/Exec[foreman_certs_config]/unless: /etc/foreman/client_cert.pem
[DEBUG 2015-02-20 18:05:10 main]  /Stage[main]/Certs::Foreman/Exec[foreman_certs_config]/unless: /etc/foreman/client_key.pem
[DEBUG 2015-02-20 18:05:10 main]  Class[Certs::Foreman]: The container Stage[main] will propagate my refresh event
[ WARN 2015-02-20 18:05:43 main]  /Stage[main]/Foreman_proxy::Register/Foreman_smartproxy[debug-kipr-181.usersys.redhat.com]: Triggered 'refresh' from 1 events
[DEBUG 2015-02-20 18:05:43 main]  /Stage[main]/Foreman_proxy::Register/Foreman_smartproxy[debug-kipr-181.usersys.redhat.com]: The container Class[Foreman_proxy::Register] will propagate my refresh event
[DEBUG 2015-02-20 18:05:43 main]  Class[Foreman_proxy::Register]: The container Stage[main] will propagate my refresh event
[DE

@stbenjam stbenjam changed the title Revert "Fixes #9392 - Substitute foreman-config (deprecated) for foreman... refs #9392 - pass options to foreman-rake config command correctly Feb 20, 2015
@stbenjam
Copy link
Member Author

@dustints Updated

@dustints
Copy link

ACK

stbenjam added a commit that referenced this pull request Feb 20, 2015
refs #9392 - pass options to foreman-rake config command correctly
@stbenjam stbenjam merged commit 7134f38 into master Feb 20, 2015
@stbenjam stbenjam deleted the revert-50-master branch February 20, 2015 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants