refs #11737 - support cnames and add localhost cname to qpid certs #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
force-pushed
the
alternative-cn
branch
from
fdf044d to
71b7a03
Compare
| if resource[:cname].is_a?(String) | ||
| args << ['--set-cname', resource[:cname]] | ||
| else | ||
| resource[:cname].map { |cname| ['--set-cname', cname] }.flatten |
There was a problem hiding this comment.
Does this need to be added to the args array?
There was a problem hiding this comment.
That would make things actually work, yes :-)
stbenjam
force-pushed
the
alternative-cn
branch
from
71b7a03 to
465b993
Compare
stbenjam
force-pushed
the
alternative-cn
branch
from
465b993 to
f3c8884
Compare
6 tasks
stbenjam
force-pushed
the
alternative-cn
branch
from
f3c8884 to
c809c36
Compare
stbenjam
force-pushed
the
alternative-cn
branch
from
c809c36 to
a7a3043
Compare
stbenjam
force-pushed
the
alternative-cn
branch
from
a7a3043 to
510dfb3
Compare
stbenjam
force-pushed
the
alternative-cn
branch
from
510dfb3 to
943f78f
Compare
stbenjam
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
@stbenjam is there a way to force the |
|
Maybe in the installer pre hook on the 3.2->3.3 upgrade? https://github.com/Katello/katello-installer/blob/master/hooks/pre/20-certs_update.rb |
|
Will this also require new certs to be generated for each capsule? |
|
Yea, unfortunately, everywhere qpid runs |
ehelms
approved these changes
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require the user to do a
--certs-update-allfor the next upgrade, so qpid gets the new cert with the additional CN.