Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path to named-checkconf on FreeBSD/DragonFly BSD #271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fraenki
Copy link

@fraenki fraenki commented Jan 12, 2025

Fixes the following error:

Error: Execution of '/usr/local/sbin/named-checkconf /usr/local/etc/namedb/zones.conf20250112-57376-i5p19x' returned 1: Error: Could not execute posix command: No such file or directory - /usr/local/sbin/named-checkconf

Turns out the path to named-checkconf is incorrect:

$ uname -o
FreeBSD
$ which named-checkconf
/usr/local/bin/named-checkconf

@fraenki
Copy link
Author

fraenki commented Jan 12, 2025

The test failure does not seem to be related to this PR, the previous test already failed.

@ekohl
Copy link
Member

ekohl commented Jan 12, 2025

Do you happen to know if this change was specific to some FreeBSD version? Right now we only list FreeBSD 11 in our metadata.json which is rather ancient by now.

@fraenki
Copy link
Author

fraenki commented Jan 13, 2025

@ekohl It seems like this was changed with the introduction of the bind 9.18 port. The bind 9.16 port still installed it into the sbin folder:
https://github.com/freebsd/freebsd-ports/blob/cfada54fb345c0886e2e11f0448bc0f7ed797299/dns/bind916/pkg-plist#L321
So it looks like this was introduced ~3 years ago during the FreeBSD 13.0 lifecycle.

@fraenki
Copy link
Author

fraenki commented Jan 13, 2025

Should I add FreeBSD 13 and 14 to metadata.json, and remove FreeBSD 11?

@ekohl
Copy link
Member

ekohl commented Jan 13, 2025

Yes please.

@fraenki
Copy link
Author

fraenki commented Jan 13, 2025

Done.

@ekohl
Copy link
Member

ekohl commented Jan 13, 2025

I wanted to change the PR summary to be about the OS version but realized we also only mention DragonFly BSD. Can we safely update that to 6 and does it include bind 9.18? I get the impression they used to ship bind but no longer do, but perhaps I'm just missing something.

@fraenki
Copy link
Author

fraenki commented Jan 13, 2025

I don't have a DragonFly machine at hand, but they definitely use the same path since about ~3 years:
https://github.com/DragonFlyBSD/DPorts/blob/master/dns/bind918/pkg-plist#L2

So I'd say: let's bump the DragonFly version to 6, too.

@ekohl
Copy link
Member

ekohl commented Jan 13, 2025

Ah, I couldn't find their ports but that looks correct. Let's bump it to 6 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants