Drop server_ssl_certs_dir parameter #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Nov 5, 2021
This parameter could be used to configure a directory with CA certificates to be trusted. This parameter is generally not used and $server_ssl_cert is preferred. The parameter was introduced in 08911c3 to override the default in puppetlabs-apache. Prior to version 2.1.0 it used to default to the system store, which created a security problem. In puppetlabs-apache 2.1.0 the default was changed to undef[1]. Since this module depends on >= 5.5.0, it's safe to assume we don't need it. It can still be set via Hiera: foreman::config::apache::https_vhost_options: ssl_certs_dir: /path/to/certs/dir [1]: puppetlabs/puppetlabs-apache@7bb35c2
ekohl
force-pushed
the
drop-ssl-certs-dir-parameter
branch
from
1fd1210 to
41f797b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter could be used to configure a directory with CA certificates to be trusted. This parameter is generally not used and
$server_ssl_certis preferred.The parameter was introduced in 08911c3 to override the default in puppetlabs-apache. Prior to version 2.1.0 it used to default to the system store, which created a security problem. In puppetlabs-apache 2.1.0 the default was changed to undef. Since this module depends on >= 5.5.0, it's safe to assume we don't need it.
It can still be set via Hiera: