Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25170 - Prefix user params with initial_ #701

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Fixes #25170 - Prefix user params with initial_ #701

merged 1 commit into from
Jan 8, 2019

Conversation

chris1984
Copy link
Member

No description provided.

@chris1984
Copy link
Member Author

chris1984 commented Dec 17, 2018 •
edited
Loading

@ekohl somehow when i pushed up my changes on #674 it closed it and i cant reopen even force pushing so here is the updated one. I have updated all the params but the tests are failing on fixtures. 2 of the tests are green

@chris1984
Copy link
Member Author

@ekohl updated and tests are green.

@ekohl ekohl merged commit 81fcf11 into theforeman:master Jan 8, 2019
@ekohl ekohl changed the title Fixes #25170 - Update admin/pass param to initial_param. Fixes #25170 - Prefix user params with initial_ Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Backwards incompatible Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris1984 @ekohl @theforeman-bot