Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle websockets_encrypt as a boolean #702

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 19, 2018

Since Foreman 97c34475c9e674db6443b28e03a5e4d94d585f2e (1.10+) this is actually a boolean. The string 'off' would be interpreted as the value true.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending travis

@mmoll
Copy link
Contributor

mmoll commented Dec 22, 2018

@ekohl tests need updating

Since Foreman 97c34475c9e674db6443b28e03a5e4d94d585f2e (1.10+) this is
actually a boolean. The string 'off' would be interpreted as the value
true.
@ekohl
Copy link
Member Author

ekohl commented Dec 29, 2018

Updated

@mmoll mmoll merged commit ccfc663 into theforeman:master Dec 29, 2018
@mmoll
Copy link
Contributor

mmoll commented Dec 29, 2018

merged, bedankt @ekohl!

@ekohl ekohl added the Bug label Jan 14, 2019
@ekohl ekohl deleted the websockets-fix branch April 16, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants