Clarify the defaults switched #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs more red flashing 10 foot letters... ;) |
ekohl
force-pushed
the
add-compatibility-warning
branch
from
513c1b7 to
b91ed13
Compare
ekohl
force-pushed
the
add-compatibility-warning
branch
from
b91ed13 to
022fcb9
Compare
|
How about this? |
alexjfisher
approved these changes
Jan 18, 2019
tbrisker
reviewed
Jan 19, 2019
|
|
||
| | Setting | module 11.x with 1.20 | module 10.x with 1.20 | | ||
| |----------------------------|-----------------------|-----------------------| | ||
| | `authentication` (`login`) | false | true | |
There was a problem hiding this comment.
in 1.20 and earlier login still defaults to true if missing (https://github.com/theforeman/foreman/blob/1.20-stable/config/settings.rb#L11 and https://github.com/theforeman/foreman/blob/1.19-stable/config/settings.rb#L10)
There was a problem hiding this comment.
But not in 1.18 which I was still using...
https://github.com/theforeman/foreman/blob/1.18-stable/config/settings.rb#L11
I was prepping for upgrading to 1.19 by first updating Puppet modules and refactoring my profiles etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.