Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove references to ruby193-* packages #741

Merged
merged 1 commit into from
Jul 17, 2019
Merged

remove references to ruby193-* packages #741

merged 1 commit into from
Jul 17, 2019

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 17, 2019

No description provided.

tbrisker
tbrisker approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long overdue :) thanks @evgeni !

ekohl
ekohl approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the branch name

@evgeni
Copy link
Member Author

evgeni commented Jul 17, 2019

Finally someone who takes the time to appreciate a good branch name :)

@ohadlevy
Copy link
Member

Finally someone who takes the time to appreciate a good branch name :)

is that in German? ;)

@evgeni
Copy link
Member Author

evgeni commented Jul 17, 2019

I'd say the travis failures are unrelated

@ekohl ekohl merged commit a14059f into theforeman:master Jul 17, 2019
@ekohl
Copy link
Member

ekohl commented Jul 17, 2019

Yes, I need to figure out why the journald logger is broken on EL7. It used to work and may indicate an actual regression.

@evgeni evgeni deleted the die-ruby193-die branch July 17, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evgeni @ohadlevy @ekohl @tbrisker @theforeman-bot