-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for rails_cache_store #762
Conversation
I think the failed tests are unrelated, because it is just Debian failing for "install foreman with prometheus" which runs fine on CentOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the cache type is redis, it should install the foreman-redis
package.
@ekohl I have it included now (also in the tests). Tests are still running. |
@dgoetz can I support you in any way on getting this merged? I would love to experiment with this in our release environment. |
@laugmanuel: No, it needs re-review and comments from @ekohl and @ehelms, so I get input for further adjustments if required. |
864aca8
to
042b281
Compare
Rebased to resolve merge conflicts, tests failing on debian for statsd seem to be unrelated. |
I rebased and addressed the comments.
|
@dgoetz This will need another rebase |
Rebased and tests are green except from beaker tests for puppet 5 testing journald, statsd and prometheus, not sure if this is related. |
This allows to make use of redis as backend, but still defaults to file.
Tests are green now, and I hope I have addressed everything. |
Thanks! |
This allows to make use of redis as backend, but still defaults to file.
@timogoebel: Can you have a look as the feature was implemented by you and so you perhaps know best if the parameters make sense in this way?