Ensure plugins are installed before the database #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously plugins were installed after the database was set up. This was usually ok because all the plugins did database migrations after being installed. However, if the migration would need any config, it could still fail. This changes it to make sure all plugins are installed and (mostly) configured before the database is done setting up. If any plugin needs additional configuration to be present before migrating and seeding, the foreman::plugin::$myplugin class needs to additionally take care of this. Currently all existing classes do where needed.
ekohl
force-pushed
the
refactor-chaining
branch
from
15528e3 to
82de65f
Compare
ehelms
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously plugins were installed after the database was set up. This was usually ok because all the plugins did database migrations after being installed. However, if the migration would need any config, it could still fail.
This changes it to make sure all plugins are installed and (mostly) configured before the database is done setting up. If any plugin needs additional configuration to be present before migrating and seeding, the foreman::plugin::$myplugin class needs to additionally take care of this. Currently all existing classes do where needed.