Fixes #29148 - Use Puma instead of Passenger by default

[sthirugn]

No description provided.

[ekohl]

Two nits about the PR title: the # is significant (note that under the Checks tab no issue was linked). I'd also say what you are doing, so something like Use Puma instead of Passenger by default.

[sthirugn]

Test results
I was able to test locally using the following vagrant configuration. foreman service came up successfully with the required puma processes.

Vagrant box definition

centos7-puma-default:
  box: centos7-katello-nightly
  memory: 12000
  ansible:
    variables: # defaults in roles/hammer_devel/defaults/main.yml
      hammer_devel_github_username: blah
      foreman_repositories_environment: staging
      foreman_installer_options:
        - "--puppet-server-jvm-min-heap-size 300M"
        - "--puppet-server-jvm-max-heap-size 300M"
      foreman_installer_module_prs:
        - theforeman/puppet-foreman/802

I was able to do the following without any issues:

• upload subscription
• Enable repo
• Sync custom repo
• Create Content view
• Publish/Promote the Content view

[sthirugn]

Updated spec tests

[sthirugn]

Updated more spec tests and squashed all the commits. Ready for the final review once the tests pass.

[ehelms]

Looks good, I think the tests failing are same as master and this is good to go in for nightly to begin using puma.

[ekohl]

Currently no migration has been written to switch existing installations. IMHO that's fine and I'd feel comfortable not trying to migrate everyone in 2.1, leaving just fresh installations. Just wanted to make sure we're all on the same page about that rather than an omission.

[ehelms]

Yep, the migration is in progress. I prefer to upgrade users to the same as freah installs to reduce matrix of deployment types and allow hardening of puma.

…

On Sun, Mar 1, 2020, 10:56 AM Ewoud Kohl van Wijngaarden < ***@***.***> wrote: Currently no migration has been written to switch existing installations. IMHO that's fine and I'd feel comfortable not trying to migrate everyone in 2.1, leaving just fresh installations. Just wanted to make sure we're all on the same page about that rather than an omission. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#802?email_source=notifications&email_token=AACHT467YECRJZSJODRNWATRFKATBA5CNFSM4K2PY2OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNC4RA#issuecomment-593112644>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHT46YK4XAPZWGPVNB7HTRFKATBANCNFSM4K2PY2OA> .

[sthirugn]

Tested this change in stage and it worked great:

# journalctl -u foreman -f
-- Logs begin at Mon 2020-03-02 17:45:39 UTC. --
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] Puma starting in cluster mode...
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] * Version 3.11.4 (ruby 2.5.5-p157), codename: Love Song
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] * Min threads: 0, max threads: 16
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] * Environment: production
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] * Process workers: 2
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] * Phased restart available
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] * Listening on tcp://127.0.0.1:3000
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] Use Ctrl-C to stop
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] - Worker 0 (pid: 17647) booted, phase: 0
Mar 02 17:59:55 centos7-puma-staging-test.apex.example.com foreman[17405]: [17464] - Worker 1 (pid: 17656) booted, phase: 0

Box definition:

centos7-puma-staging-test:
  box: centos7-katello-nightly
  memory: 12000
  ansible:
    variables: # defaults in roles/hammer_devel/defaults/main.yml
      hammer_devel_github_username: *****
      foreman_repositories_environment: staging
      foreman_installer_options:
        - "--puppet-server-jvm-min-heap-size 300M"
        - "--puppet-server-jvm-max-heap-size 300M"