Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plugin_prefix to determine plugin packages #809

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 5, 2020

Previously this was duplicating the plugin prefix for packages that didn't follow the convention. By using regsubst, this can be avoided. This removes the need for separate params classes.

Previously this was duplicating the plugin prefix for packages that
didn't follow the convention. By using regsubst, this can be avoided.
This removes the need for separate params classes.
@ekohl
Copy link
Member Author

ekohl commented Mar 5, 2020

Backwards incompatible because this drops the package parameter

@mmoll mmoll merged commit d389858 into theforeman:master Mar 5, 2020
@mmoll
Copy link
Contributor

mmoll commented Mar 5, 2020

merged, bedankt @ekohl!

@ekohl ekohl deleted the simplify-plugin-params branch March 5, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants