-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: make refresh_cache and request_timeout params global #884
Conversation
Spec tests failed due to two reasons:
IMHO, two possible behaviors, the configuration file can be filled by
The question is what the foreman team prefers? Note: If someone have a better direction, show me the way ;-) |
@ekohl Do you have any point of view on this? Who should I reach in Foreman about this topic? |
0fbfcfc
to
2593087
Compare
I would accept this change (provided tests pass). |
2593087
to
9ec324e
Compare
Considering the name of these parameters, they should be affect system-wide configuration but were set in root configuration file. This commit fixes this unexpected behavior.
8121237
to
c784e66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Considering the name of these parameters, they should be affect system-wide configuration but were set in root configuration file.
This commit fixes this unexpected behavior.