Fixes #32175: Allow toggling task backup when cleaning them up

[ehelms]

Changes the default behavior to disable task backup when enabling
the task cleanup cron job. Users who still want backups kept
on disk will need to set the parameter to true.

[ehelms]

Configuration for task-backups are also guided by https://github.com/theforeman/foreman-tasks/blob/master/config/foreman-tasks.yaml.example which is laid down by the RPM and not under Puppets control. This focuses on making it so that the cron job does not by default create backups as the environment variables override the base config. If a user chooses to run the cleanup by hand they have to adjust any specific configuration differences they would want.

Putting https://github.com/theforeman/foreman-tasks/blob/master/config/foreman-tasks.yaml.example under puppet control seemed like a much bigger change and handling the :rules: section as tricky given hashes are never fun and are further complicated when translated to installer parameters.

[ehelms]

Needs #923

[ekohl]

Small nit, otherwise 👍

[ehelms]

@adamruzicka Take a look if you have time, in case you have concerns around this approach and reasoning

[adamruzicka]

I'm fine with this approach, +1 from me

[ekohl]

I'm debating whether this is an enhancement or breaking change. It does change behavior so technically it would be. On the other hand, it is a plugin. I also think the next release should be major anyway since I want to finish #862.

[ehelms]

I'm debating whether this is an enhancement

👍